• Resolves: [Bug]: set 'appstoreenabled' => false, still show Warning logging #47833
• Resolves: apps list is not loaded from a custom URL

I might miss something or misunderstand what's happening here.

Summary

fix(appstoreFetcher): remove unneeded warning

• Fixes the root cause of [Bug]: set 'appstoreenabled' => false, still show Warning logging #47833
• The root cause - warning in AppFetcher added in fix(appstore): Return an empty array in case of fail #46555

Base get in Fetcher returns [] in 2 cases:

1. Something went wrong, and the request failed — unexpected
   • In this case warning in AppFetcher is unnecessary, because it is already covered by base Fetcher:
     

     server/lib/private/App/AppStore/Fetcher/Fetcher.php

     Lines 172 to 174 in b9fb1db

     	} catch (ConnectException $e) {
     	$this->logger->warning('Could not connect to appstore: ' . $e->getMessage(), ['app' => 'appstoreFetcher']);
     	return [];

2. No app list should have been fetched (e.g. disabled)
   • In this case there should be no warning => removed to fix the linked issue

fix(appstoreFetcher): get app list from custom app store

• Fixes regression from fix(appstore): return if appstore is manually disabled #47834
• New check misses one case: appstore enabled, no internet, but it is OK because a custom local app store is set up. As a result - it doesn't try to load the list from custom local URL.
• This new check in AppFetcher is unnecessary as already correctly covered by the base method:
  

  server/lib/private/App/AppStore/Fetcher/Fetcher.php

  Lines 123 to 125 in b9fb1db

  	if (!$appstoreenabled || (!$internetavailable && $isDefaultAppStore)) {
  	return [];
  	}

• Because the new info log may be useful - added it to the base method

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)